Re: [PATCH v2 3/5] tests/cgroup: use cgroup.kill in cg_killall()
From: Shakeel Butt <hidden>
Date: 2021-05-05 16:42:08
On Mon, May 3, 2021 at 7:40 AM Christian Brauner [off-list ref] wrote:
From: Christian Brauner <christian.brauner-GeWIH/nMZzLQT0dZR+AlfA@public.gmane.org> If cgroup.kill file is supported make use of it. Cc: Tejun Heo <redacted> Cc: cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Acked-by: Roman Gushchin <redacted> Signed-off-by: Christian Brauner <christian.brauner-GeWIH/nMZzLQT0dZR+AlfA@public.gmane.org>
Reviewed-by: Shakeel Butt <redacted>
quoted hunk
--- /* v2 */ - Roman Gushchin [off-list ref]: - Fix whitespace. --- tools/testing/selftests/cgroup/cgroup_util.c | 4 ++++ 1 file changed, 4 insertions(+)diff --git a/tools/testing/selftests/cgroup/cgroup_util.c b/tools/testing/selftests/cgroup/cgroup_util.c index 027014662fb2..f60f7d764690 100644 --- a/tools/testing/selftests/cgroup/cgroup_util.c +++ b/tools/testing/selftests/cgroup/cgroup_util.c@@ -252,6 +252,10 @@ int cg_killall(const char *cgroup) char buf[PAGE_SIZE]; char *ptr = buf; + /* If cgroup.kill exists use it. */ + if (!cg_write(cgroup, "cgroup.kill", "1")) + return 0;
Now cg_killall will kill all the processes in the tree rooted at cgroup which I think is fine.
+
if (cg_read(cgroup, "cgroup.procs", buf, sizeof(buf)))
return -1;
--
2.27.0