Thread (6 messages) 6 messages, 3 authors, 2021-02-23

Re: [PATCH 00/20] Manual replacement of all strlcpy in favor of strscpy

From: Romain Perier <romain.perier@gmail.com>
Date: 2021-02-23 09:31:30
Also in: alsa-devel, dri-devel

Le lun. 22 févr. 2021 à 17:36, Shuah Khan [off-list ref] a
écrit :
Cool. A quick check shows me 1031 strscpy() calls with no return
checks. All or some of these probably need to be reviewed and add
return checks. Is this something that is in the plan to address as
part of this work?

thanks,
-- Shuah
Hi,

Initially, what we planned with Kees is to firstly replace all calls with
error handling codes (like this series does),
and then replace all other simple calls (without error handling). However,
we can also start a discussion about this topic, all suggestions are
welcome.

I am not sure that it does make sense to check all returns code in all
cases (for example in arch/alpha/kernel/setup.c, there are a ton of other
examples in the kernel). But a general review (as you suggest), would make
sense.

Regards,
Romain
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help