Thread (6 messages) 6 messages, 6 authors, 2021-02-06

Re: [PATCH v2] mm: memcontrol: replace the loop with a list_for_each_entry()

From: Roman Gushchin <hidden>
Date: 2021-02-04 18:43:24
Also in: linux-mm, lkml

On Fri, Feb 05, 2021 at 12:30:55AM +0800, Muchun Song wrote:
The rule of list walk has gone since:

 commit a9d5adeeb4b2 ("mm/memcontrol: allow to uncharge page without using page->lru field")

So remove the strange comment and replace the loop with a
list_for_each_entry().

There is only one caller of the uncharge_list(). So just fold it into
mem_cgroup_uncharge_list() and remove it.

Signed-off-by: Muchun Song <redacted>
---
v2:
 - Fold uncharge_list() to mem_cgroup_uncharge_list().

 mm/memcontrol.c | 35 ++++++++---------------------------
 1 file changed, 8 insertions(+), 27 deletions(-)
Nice cleanup!

Acked-by: Roman Gushchin <redacted>

Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help