Re: [PATCH] cgroup: Remove unnecessary call to strstrip()
From: Tejun Heo <hidden>
Date: 2021-01-15 20:33:33
Also in:
lkml
On Thu, Jan 14, 2021 at 01:44:27PM +0100, Michal Koutný wrote:
Hello. On Sun, Jan 03, 2021 at 02:50:01AM +0000, Hao Lee [off-list ref] wrote:quoted
The string buf will be stripped in cgroup_procs_write_start() before it is converted to int, so remove this unnecessary call to strstrip().Good catch, Hao. Perhaps the code be then simplified a bit -- >8 -- From: =?UTF-8?q?Michal=20Koutn=C3=BD?= <mkoutny-IBi9RG/b67k@public.gmane.org> Date: Thu, 14 Jan 2021 13:23:39 +0100 Subject: [PATCH] cgroup: cgroup.{procs,threads} factor out common parts MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The functions cgroup_threads_start and cgroup_procs_start are almost identical. In order to reduce duplication, factor out the common code in similar fashion we already do for other threadgroup/task functions. No functional changes are intended. Suggested-by: Hao Lee <redacted> Signed-off-by: Michal Koutný <mkoutny-IBi9RG/b67k@public.gmane.org>
Applied to cgroup/for-5.12 w/ minor description update suggested by Daniel. Thanks. -- tejun