Thread (3 messages) 3 messages, 3 authors, 2021-01-15

Re: [PATCH v3] cgroup-v1: add disabled controller check in cgroup1_parse_param()

From: Tejun Heo <hidden>
Date: 2021-01-15 20:13:05
Also in: lkml

On Fri, Jan 15, 2021 at 05:37:17PM +0800, Chen Zhou wrote:
When mounting a cgroup hierarchy with disabled controller in cgroup v1,
all available controllers will be attached.
For example, boot with cgroup_no_v1=cpu or cgroup_disable=cpu, and then
mount with "mount -t cgroup -ocpu cpu /sys/fs/cgroup/cpu", then all
enabled controllers will be attached except cpu.

Fix this by adding disabled controller check in cgroup1_parse_param().
If the specified controller is disabled, just return error with information
"Disabled controller xx" rather than attaching all the other enabled
controllers.

Fixes: f5dfb5315d34 ("cgroup: take options parsing into ->parse_monolithic()")
Signed-off-by: Chen Zhou <redacted>
Reviewed-by: Zefan Li <redacted>
Applied to cgroup/for-5.11-fixes.

Thanks.

-- 
tejun
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help