Re: [PATCH v2] mm: memcontrol: eliminate redundant check in __mem_cgroup_insert_exceeded()
From: Johannes Weiner <hidden>
Date: 2020-10-12 14:00:39
Also in:
linux-mm, lkml
From: Johannes Weiner <hidden>
Date: 2020-10-12 14:00:39
Also in:
linux-mm, lkml
On Mon, Oct 12, 2020 at 09:16:07AM -0400, Miaohe Lin wrote:
The mz->usage_in_excess >= mz_node->usage_in_excess check is exactly the else case of mz->usage_in_excess < mz_node->usage_in_excess. So we could replace else if (mz->usage_in_excess >= mz_node->usage_in_excess) with else equally. Also drop the comment which doesn't really explain much. Acked-by: Michal Hocko <mhocko-IBi9RG/b67k@public.gmane.org> Signed-off-by: Miaohe Lin <redacted>
Looks good to me. Acked-by: Johannes Weiner <redacted>