Re: [PATCH v16 21/22] mm/pgdat: remove pgdat lru_lock
From: Alexander Duyck <hidden>
Date: 2020-07-17 21:10:10
Also in:
linux-mm, lkml
On Fri, Jul 10, 2020 at 5:59 PM Alex Shi [off-list ref] wrote:
quoted hunk ↗ jump to hunk
Now pgdat.lru_lock was replaced by lruvec lock. It's not used anymore. Signed-off-by: Alex Shi <redacted> Cc: Andrew Morton <akpm@linux-foundation.org> Cc: Konstantin Khlebnikov <redacted> Cc: Hugh Dickins <hughd@google.com> Cc: Johannes Weiner <hannes@cmpxchg.org> Cc: linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org Cc: cgroups@vger.kernel.org --- include/linux/mmzone.h | 1 - mm/page_alloc.c | 1 - 2 files changed, 2 deletions(-)diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h index 36c1680efd90..8d7318ce5f62 100644 --- a/include/linux/mmzone.h +++ b/include/linux/mmzone.h@@ -735,7 +735,6 @@ struct deferred_split { /* Write-intensive fields used by page reclaim */ ZONE_PADDING(_pad1_) - spinlock_t lru_lock; #ifdef CONFIG_DEFERRED_STRUCT_PAGE_INIT /*diff --git a/mm/page_alloc.c b/mm/page_alloc.c index e028b87ce294..4d7df42b32d6 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c@@ -6721,7 +6721,6 @@ static void __meminit pgdat_init_internals(struct pglist_data *pgdat) init_waitqueue_head(&pgdat->pfmemalloc_wait); pgdat_page_ext_init(pgdat); - spin_lock_init(&pgdat->lru_lock); lruvec_init(&pgdat->__lruvec); }
This patch would probably make more sense as part of patch 18 since you removed all of the users of this field there.