Thread (3 messages) 3 messages, 2 authors, 2020-01-20

Re: [PATCH v4 5/6] clone3: allow spawning processes into cgroups

From: Oleg Nesterov <hidden>
Date: 2020-01-20 15:39:42
Also in: linux-api, lkml

On 01/17, Christian Brauner wrote:
+static int cgroup_css_set_fork(struct task_struct *parent,
+			       struct kernel_clone_args *kargs)
...
+	kargs->cset = find_css_set(cset, dst_cgrp);
+	if (!kargs->cset) {
+		ret = -ENOMEM;
+		goto err;
+	}
+
+	if (cgroup_is_dead(dst_cgrp)) {
+		ret = -ENODEV;
+		goto err;
                ^^^^^^^^

this looks wrong... don't we need put_css_set(kargs->cset) before "goto err" ?

Oleg.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help