Re: [PATCH 14/14] mm/lru: fix the comments of lru_lock
From: Matthew Wilcox <willy@infradead.org>
Date: 2019-08-20 14:00:24
Also in:
linux-mm, lkml
On Tue, Aug 20, 2019 at 05:48:37PM +0800, Alex Shi wrote:
quoted hunk ↗ jump to hunk
@@ -159,7 +159,7 @@ static inline bool free_area_empty(struct free_area *area, int migratetype) struct pglist_data; /* - * zone->lock and the zone lru_lock are two of the hottest locks in the kernel. + * zone->lock and the lru_lock are two of the hottest locks in the kernel. * So add a wild amount of padding here to ensure that they fall into separate * cachelines. There are very few zone structures in the machine, so space * consumption is not a concern here.
But after this patch series, the lru lock is no longer stored in the zone. So this comment makes no sense.
quoted hunk ↗ jump to hunk
@@ -295,7 +295,7 @@ struct zone_reclaim_stat { struct lruvec { struct list_head lists[NR_LRU_LISTS]; - /* move lru_lock to per lruvec for memcg */ + /* perf lruvec lru_lock for memcg */
What does the word 'perf' mean here?