Re: [PATCH v4.15-rc9] sched, cgroup: Don't reject lower cpu.max on ancestors
From: Tejun Heo <tj@kernel.org>
Date: 2018-02-12 17:25:03
Also in:
lkml
From: Tejun Heo <tj@kernel.org>
Date: 2018-02-12 17:25:03
Also in:
lkml
On Mon, Jan 22, 2018 at 11:26:18AM -0800, Tejun Heo wrote:
While adding cgroup2 interface for the cpu controller, 0d5936344f30
("sched: Implement interface for cgroup unified hierarchy") forgot to
update input validation and left it to reject cpu.max config if any
descendant has set a higher value.
cgroup2 officially supports delegation and a descendant must not be
able to restrict what its ancestors can configure. For absolute
limits such as cpu.max and memory.max, this means that the config at
each level should only act as the upper limit at that level and
shouldn't interfere with what other cgroups can configure.
This patch updates config validation on cgroup2 so that the cpu
controller follows the same convention.
Signed-off-by: Tejun Heo <tj@kernel.org>
Fixes: 0d5936344f30 ("sched: Implement interface for cgroup unified hierarchy")Applied to cgroup/for-4.16-fixes. Thanks. -- tejun