Re: [GIT PULL] cgroup fixes for v4.15-rc7

On Mon, Jan 08, 2018 at 11:23:03AM -0800, Linus Torvalds wrote:

On Mon, Jan 8, 2018 at 11:20 AM, Linus Torvalds
[off-list ref] wrote:

quoted

Use "strscpy()", which got this _right_.

Oh Christ.

It actually did that initially. And then it was changed to the broken
code due to some idiotic broken warning by tools that don't do the
right thing.

Dang, I was reading the different str*cpy() functions and suggested
strscpy() and then forgot about it and blindly applied strlcpy()
blindly after the build warning report.  It'd be great to weed out the
useless ones.  These are places where truncation is fine.  Would the
right thing to do be adding (void) in front, which is kinda ugly?

Thanks.

-- 
tejun