Re: [PATCHSET v2] slab: make memcg slab destruction scalable
From: Joonsoo Kim <hidden>
Date: 2017-01-18 07:48:51
Also in:
linux-mm, lkml
From: Joonsoo Kim <hidden>
Date: 2017-01-18 07:48:51
Also in:
linux-mm, lkml
On Tue, Jan 17, 2017 at 08:49:13AM -0800, Tejun Heo wrote:
Hello, On Tue, Jan 17, 2017 at 09:12:57AM +0900, Joonsoo Kim wrote:quoted
Could you confirm that your series solves the problem that is reported by Doug? It would be great if the result is mentioned to the patch description. https://bugzilla.kernel.org/show_bug.cgi?id=172991So, that's an issue in the creation path which is already resolved by switching to an ordered workqueue (it'd probably be better to use per-cpu wq w/ @max_active == 1 tho). This patchset is about relesae path. slab_mutex contention would definitely go down with this but I don't think there's more connection to it than that.
That problem is caused by slow release path and then contention on the slab_mutex. With an ordered workqueue, kworker would not be created a lot but it can be possible that a lot of work items to create a new cache for memcg is pending for a long time due to slow release path. Your patchset replaces optimization for release path so it's better to check that the work isn't pending for a long time in above workload. Thanks.