Thread (2 messages) 2 messages, 2 authors, 2016-09-20

Re: [PATCH] cgroup/cpu: Fix tg_has_rt_task() malfunction

From: Tejun Heo <tj@kernel.org>
Date: 2016-09-20 19:41:17
Also in: lkml

On Sun, Sep 18, 2016 at 11:23:10PM +0900, yingooyim wrote:
Hi,
I am a graduate student of System Software Lab. at Konkuk University
(http://sslab.konkuk.ac.kr).

This patch is to fix the malfunction of tg_has_rt_tasks(). The
tg_has_rt_tasks() function is supposed to determine whether a task
group includes an "rt task" or not. However, it returns true for
"dl task" too. The origin of this problem is that rt_task() called
by tg_has_rt_tasks() returns true for dl tasks. Because of this
problem, tg_rt_schedulable() that calls tg_has_rt_tasks() returns
–EBUSY if we try to initialize an rt task group, while a dl task
is running. That is, you cannot run an rt task group when there
exists a dl task in the system. Our patch provided in this post
simply makes the tg_has_rt_tasks() function return false for dl
tasks by calling dl_task() in the conditional statement.

Previously we have provided another patch for rt_task() (more
precisely rt_prio()) to resolve this problem as follows:
https://patchwork.kernel.org/patch/9299267/
However, a dependency issue were raised. So, we think that it is
better to modify tg_has_rt_tasks() instead of rt_task() itself.

Signed-off-by: Yin-goo Yim <redacted>
Can you please repost with scheduler maintainers cc'd?

 Ingo Molnar [off-list ref]
 Peter Zijlstra [off-list ref]

Thanks.

-- 
tejun
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help