Thread (12 messages) 12 messages, 3 authors, 2016-08-10

Re: [PATCH 2/4] kernfs: make kernfs_path*() behave in the style of strlcpy()

From: Serge E. Hallyn <hidden>
Date: 2016-08-09 20:14:45
Also in: lkml

Quoting Tejun Heo (tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org):
Hello, Serge.

On Tue, Aug 09, 2016 at 10:33:05AM -0500, Serge E. Hallyn wrote:
quoted
quoted
+	for (i = depth_to - 1; i >= 0; i--) {
+		for (kn = kn_to, j = 0; j < i; j++)
+			kn = kn->parent;
This is O(n^2) where n is the path depth.  It's not a hot path, though, do
we care?
I don't think it matters.  It's a slow path and cgroup hierarchies
aren't supposed to be super deep to begin with.  If it ever does, we
can replace the cgroup->ancestor_ids[] array with ancestor pointer
array and walk that instead.

Thanks.
Ok, thanks

Acked-by: Serge Hallyn <redacted>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help