Hello,
On Sun, Apr 17, 2016 at 03:04:32PM -0500, serge.hallyn-GeWIH/nMZzLQT0dZR+AlfA@public.gmane.org wrote:
quoted hunk ↗ jump to hunk
+static int cgroup_show_path(struct seq_file *sf, struct kernfs_node *kf_node,
+ struct kernfs_root *kf_root)
+{
+ int len = 0, ret = 0;
+ char *buf = NULL;
+ struct cgroup_namespace *ns = current->nsproxy->cgroup_ns;
+ struct cgroup_root *kf_cgroot = cgroup_root_from_kf(kf_root);
+ struct cgroup *ns_cgroup;
+
+ mutex_lock(&cgroup_mutex);
+ spin_lock_bh(&css_set_lock);
+ ns_cgroup = cset_cgroup_from_root(ns->root_cset, kf_cgroot);
+ len = kernfs_path_from_node(kf_node, ns_cgroup->kn, NULL, 0);
+ if (len > 0)
+ buf = kmalloc(len + 1, GFP_ATOMIC);
Ugh... What's up with GFP_ATOMIC? Just allocate maximum sized buffer
before grabbing any locks.
Thanks.
--
tejun