On Sun, Feb 21, 2016 at 8:39 PM, Leon Romanovsky [off-list ref] wrote:

On Sun, Feb 21, 2016 at 07:41:08PM +0530, Parav Pandit wrote:

quoted

CONFIG_CGROUP_RDMA

On Sun, Feb 21, 2016 at 7:15 PM, Leon Romanovsky [off-list ref] wrote:

quoted

On Sun, Feb 21, 2016 at 05:03:05PM +0530, Parav Pandit wrote:

quoted

On Sun, Feb 21, 2016 at 1:13 PM, Leon Romanovsky [off-list ref] wrote:

quoted

On Sat, Feb 20, 2016 at 04:30:04PM +0530, Parav Pandit wrote:
Can you place this ifdef before declaring struct rdma_cgroup?

Yes. I missed out this cleanup. Done locally now.

Great, additional thing which spotted my attention was related to
declaring and using the new cgroups functions. There are number of
places where you protected the calls by specific ifdefs in the
IB/core c-files and not in h-files as it is usually done.

ib_device_register_rdmacg, ib_device_unregister_rdmacg are the only
two functions called from IB/core as its tied to functionality.
They can also be implemented as NULL call when CONFIG_CGROUP_RDMA is undefined.
(Similar to ib_rdmacg_try_charge and others).
I didn't do because occurrence of call of register and unregister is
limited to single file and only twice compare to charge/uncharge
functions.
Either way is fine with me, I can make the changes which you
described. Let me know.

Please do,
IMHO, it is better to have one place which handles all relevant ifdefs
and functions. IB/core doesn't need to know about cgroups implementation.

ok. Done. Thanks for the review. I will accumulate more comments from
Tejun and others before spinning v7.