Re: [PATCH 5/5] mm: workingset: per-cgroup cache thrash detection
From: Vladimir Davydov <hidden>
Date: 2016-01-27 14:58:45
Also in:
linux-mm, lkml
On Tue, Jan 26, 2016 at 04:00:06PM -0500, Johannes Weiner wrote:
quoted hunk ↗ jump to hunk
diff --git a/include/linux/swap.h b/include/linux/swap.h index b14a2bb33514..1cf3065c143b 100644 --- a/include/linux/swap.h +++ b/include/linux/swap.h@@ -317,6 +317,7 @@ extern void lru_cache_add_active_or_unevictable(struct page *page, /* linux/mm/vmscan.c */ extern unsigned long zone_reclaimable_pages(struct zone *zone); +extern unsigned long lruvec_lru_size(struct lruvec *lruvec, enum lru_list lru);
Better declare it in mm/internal.h? And is there any point in renaming it?
quoted hunk ↗ jump to hunk
diff --git a/mm/memcontrol.c b/mm/memcontrol.c index 953f0f984392..864e237f32d9 100644 --- a/mm/memcontrol.c +++ b/mm/memcontrol.c@@ -202,11 +207,20 @@ static void unpack_shadow(void *shadow, struct zone **zonep, */ void *workingset_eviction(struct address_space *mapping, struct page *page) { + struct mem_cgroup *memcg = page_memcg(page); struct zone *zone = page_zone(page); + int memcgid = mem_cgroup_id(memcg);
This will crash in case memcg is disabled via boot param. Thanks, Vladimir