Re: [PATCH 06/14] net: tcp_memcontrol: remove dead per-memcg count of allocated sockets
From: Vladimir Davydov <hidden>
Date: 2015-11-20 09:48:41
Also in:
linux-mm, lkml, netdev
From: Vladimir Davydov <hidden>
Date: 2015-11-20 09:48:41
Also in:
linux-mm, lkml, netdev
On Thu, Nov 12, 2015 at 06:41:25PM -0500, Johannes Weiner wrote:
The number of allocated sockets is used for calculations in the soft limit phase, where packets are accepted but the socket is under memory pressure. Since there is no soft limit phase in tcp_memcontrol, and memory pressure is only entered when packets are already dropped, this is actually dead code. Remove it.
Actually, we can get into the soft limit phase due to the global limit (tcp_memory_pressure is set), but then using per-memcg sockets_allocated counter is just wrong.
As this is the last user of parent_cg_proto(), remove that too. Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>
Reviewed-by: Vladimir Davydov <redacted> -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>