Re: [PATCH 2/2] ext4: implement cgroup writeback support

From
Theodore Ts'o <tytso@mit.edu>
Date
2015-09-23 17:02:38
Also in
linux-ext4, linux-fsdevel, lkml
Reply to
Artem Bityutskiy, 2015-09-23
On Wed, Sep 23, 2015 at 04:50:53PM +0300, Artem Bityutskiy wrote:
On Wed, 2015-09-23 at 15:49 +0300, Artem Bityutskiy wrote:
quoted
On Tue, 2015-07-21 at 23:56 -0400, Theodore Ts'o wrote:
quoted
quoted
v2: Updated for MS_CGROUPWB -> SB_I_CGROUPWB.

Signed-off-by: Tejun Heo <tj@kernel.org>
Cc: "Theodore Ts'o" <tytso@mit.edu>
Cc: Andreas Dilger <adilger.kernel@dilger.ca>
Cc: <redacted>
Thanks, applied.
Hi, this patch introduces a regression - a major one, I'd say.

Symptoms: copy a bunch of file, run sync, then run 'reboot', and
after
you boot up the copied files are corrupted. So basically the user
-visible symptom is that 'sync' does not work.
Just FYI, this is the issue I briefly reported last Fri:

https://lkml.org/lkml/2015/9/18/640
Also note this performance regression reported by Dexuan Cui

	https://lkml.org/lkml/2015/9/23/333

I didn't notice these problems since I my userspace doesn't enable the
writeback cgroup.  (In fact I don't know how to do it using Debian
Jessie.)

Tejun, can you please take a look at this and give me a
recommendation?  I'm willing to wait a day or two while we try to fix
the problem, but past that point I'd like to have a fix or revert this
commit before Linus releases the next -rc release.

						- Ted
Thread (6 messages) 6 messages, 5 authors, last reply 2015-09-23
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help