Re: [PATCH 06/51] memcg: add mem_cgroup_root_css
From: Tejun Heo <tj@kernel.org>
Date: 2015-06-18 17:49:30
Also in:
linux-fsdevel, linux-mm, lkml
Possibly related (same subject, not in this thread)
- 2015-06-19 · Re: [PATCH 06/51] memcg: add mem_cgroup_root_css · Tejun Heo <hidden>
- 2015-06-19 · Re: [PATCH 06/51] memcg: add mem_cgroup_root_css · Michal Hocko <hidden>
- 2015-06-17 · Re: [PATCH 06/51] memcg: add mem_cgroup_root_css · Tejun Heo <hidden>
- 2015-06-17 · Re: [PATCH 06/51] memcg: add mem_cgroup_root_css · Michal Hocko <hidden>
- 2015-05-22 · [PATCH 06/51] memcg: add mem_cgroup_root_css · Tejun Heo <tj@kernel.org>
Hello, Michal. On Thu, Jun 18, 2015 at 01:12:27PM +0200, Michal Hocko wrote: ...
I see and yes, it makes some sense. I just think we can get rid of the
accessor functions when the struct mem_cgroup is visible and the code
can simply do &{page->}mem_cgroup->css.As long as the accessors are inline, I think it should be fine.
I have tried to compile with !CONFIG_MEMCG and !CONFIG_CGROUP_WRITEBACK without mem_cgroup_root_css defined for this configuration and mm/backing-dev.c compiles just fine. So maybe we should get rid of it rather than have a potentially tricky code?
Yeah, please feel free to queue a patch to remove it if doesn't break anything. Thanks. -- tejun -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>