Re: [PATCH 3/6] memcg: track shared inodes with dirty pages
From: Konstantin Khlebnikov <hidden>
Date: 2015-01-15 19:04:49
Also in:
linux-fsdevel, linux-mm, lkml
From: Konstantin Khlebnikov <hidden>
Date: 2015-01-15 19:04:49
Also in:
linux-fsdevel, linux-mm, lkml
On Thu, Jan 15, 2015 at 9:55 PM, Tejun Heo [off-list ref] wrote:
On Thu, Jan 15, 2015 at 09:49:14PM +0300, Konstantin Khebnikov wrote:quoted
From: Konstantin Khlebnikov <redacted> Inode is owned only by one memory cgroup, but if it's shared it might contain pages from multiple cgroups. This patch detects this situation in memory reclaiemer and marks dirty inode with flag I_DIRTY_SHARED which is cleared only when data is completely written. Memcg writeback always writes such inodes. Signed-off-by: Konstantin Khlebnikov <redacted>This conflicts with the writeback cgroup support patchset which will solve the writeback and memcg problem a lot more comprehensively. http://lkml.kernel.org/g/1420579582-8516-1-git-send-email-tj@kernel.org Thanks.
I know. Absolutely accurate per-page solution looks too complicated for me. Is there any real demand for accurate handling dirty set in shared inodes? Doing whole accounting in per-inode basis makes life so much easier.
-- tejun
-- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>