Thread (14 messages) 14 messages, 3 authors, 2014-10-08

Re: [patch 1/3] mm: memcontrol: take a css reference for each charged page

From: Vladimir Davydov <hidden>
Date: 2014-09-22 08:24:16
Also in: linux-mm, lkml

On Sat, Sep 20, 2014 at 04:00:33PM -0400, Johannes Weiner wrote:
Charges currently pin the css indirectly by playing tricks during
css_offline(): user pages stall the offlining process until all of
them have been reparented, whereas kmemcg acquires a keep-alive
reference if outstanding kernel pages are detected at that point.

In preparation for removing all this complexity, make the pinning
explicit and acquire a css references for every charged page.

Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>
Reviewed-by: Vladimir Davydov <redacted>

Nit: In __mem_cgroup_clear_mc, we have the following hunk:
	for (i = 0; i < mc.moved_swap; i++)
		css_put(&mc.from->css);
Now we can simplify it using css_put_many.

Thanks,
Vladimir

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help