Re: [PATCH] cgroup: remove redundant variable in cgroup_mount()
From: Tejun Heo <hidden>
Date: 2014-09-20 17:12:37
Also in:
lkml
From: Tejun Heo <hidden>
Date: 2014-09-20 17:12:37
Also in:
lkml
Hello, Li. On Sat, Sep 20, 2014 at 02:49:10PM +0800, Zefan Li wrote:
Both pinned_sb and new_sb indicate if a new superblock is needed, so we can just remove new_sb. Note now we must check if kernfs_tryget_sb() returns NULL, because when it returns NULL, kernfs_mount() may still re-use an existing superblock, which is just allocated by another concurent mount. Suggested-by: Tejun Heo <redacted> Signed-off-by: Zefan Li <redacted>
Ah, this is so much better. Thanks for doing this. Applied to cgroup/for-3.18.
--- Hi Tejun, I think you wanted to see the @new_sb argument removed from kernfs_mount(), but it's also used in debugfs and we can't use kernfs_tryget_sb() to replace the new_sb check.
Bummer, someday. :) Thanks. -- tejun