Re: [PATCH] cgroup: fix unbalanced locking
From: Tejun Heo <hidden>
Date: 2014-09-18 16:34:17
Also in:
lkml
From: Tejun Heo <hidden>
Date: 2014-09-18 16:34:17
Also in:
lkml
On Thu, Sep 18, 2014 at 05:28:46PM +0800, Zefan Li wrote:
cgroup_pidlist_start() holds cgrp->pidlist_mutex and then calls pidlist_array_load(), and cgroup_pidlist_stop() releases the mutex. It is wrong that we release the mutex in the failure path in pidlist_array_load(), because cgroup_pidlist_stop() will be called no matter if cgroup_pidlist_start() returns errno or not. Fixes: 4bac00d16a8760eae7205e41d2c246477d42a210 Cc: <redacted> # 3.14+ Signed-off-by: Zefan Li <redacted>
Applied to cgroup/for-3.17-fixes. Thanks. -- tejun