Re: [PATCH RFC - TAKE TWO - 02/12] block, bfq: add full hierarchical scheduling and cgroups support
From: Tejun Heo <hidden>
Date: 2014-05-30 15:39:48
Also in:
lkml
From: Tejun Heo <hidden>
Date: 2014-05-30 15:39:48
Also in:
lkml
On Fri, May 30, 2014 at 11:37:18AM -0400, Tejun Heo wrote:
On Thu, May 29, 2014 at 11:05:33AM +0200, Paolo Valente wrote:quoted
diff --git a/include/linux/cgroup_subsys.h b/include/linux/cgroup_subsys.h index 768fe44..cdd2528 100644 --- a/include/linux/cgroup_subsys.h +++ b/include/linux/cgroup_subsys.h@@ -39,6 +39,10 @@ SUBSYS(net_cls) SUBSYS(blkio) #endif +#if IS_ENABLED(CONFIG_CGROUP_BFQIO) +SUBSYS(bfqio) +#endifSo, ummm, I don't think this is a good idea. Why aren't you plugging into the blkcg infrastructure as cfq does? Why does it need to be a separate controller?
If there's something which doesn't work for bfq in blkcg, please let me know. I'd be happy to make it work. Thanks. -- tejun