Re: [PATCH] cgroup: protect modifications to cgroup_idr with cgroup_mutex
From: Michal Hocko <hidden>
Date: 2014-02-12 09:38:36
Also in:
lkml
From: Michal Hocko <hidden>
Date: 2014-02-12 09:38:36
Also in:
lkml
On Wed 12-02-14 17:26:40, Li Zefan wrote:
On 2014/2/12 17:12, Michal Hocko wrote:quoted
Li has pointed out that my previous backport was not correct because err_unlock label releases a reference to supperblock which was not taken before idr_alloc. I've also removed cgroup_mutex from free_css_id as per Li. Fixed in this version.Looks good to me!
Thanks for double checking.
Are you going to send it to stable mailing list after the fix hits mainline or use it internally?
I plan to have it tested internally and then send it later on when stable FAILED to apply mail arrives. Unless you want to send it yourself of course.
It has small conflicts with this patch that will also be backported to 3.12: https://git.kernel.org/cgit/linux/kernel/git/tj/cgroup.git/commit/kernel/cgroup.c?h=for-3.14-fixes&id=b58c89986a77a23658682a100eb15d8edb571ebb
Thanks for the heads up. Should be trivial to resolve. -- Michal Hocko SUSE Labs