Re: [PATCH 1/6] cgroup: make CONFIG_NET_CLS_CGROUP and CONFIG_NETPRIO_CGROUP bool instead of tristate
From: Neil Horman <hidden>
Date: 2014-01-17 20:38:01
Also in:
lkml
From: Neil Horman <hidden>
Date: 2014-01-17 20:38:01
Also in:
lkml
On Fri, Jan 17, 2014 at 01:11:52PM -0500, Tejun Heo wrote:
net_cls and net_prio are the only cgroups which are allowed to be built as modules. The savings from allowing the two controllers to be built as modules are tiny especially given that cgroup module support itself adds quite a bit of complexity. The following are the sizes of vmlinux with both built as module and both built as part of the kernel image with cgroup module support removed. text data bss dec 20292207 2411496 10784768 33488471 20293421 2412568 10784768 33490757 The total difference is 2286 bytes. Given that none of other controllers has much chance of being made a module and that we're unlikely to add new modular controllers, the added complexity is simply not justifiable. As a first step to drop cgroup module support, this patch changes the two config options to bool from tristate and drops module related code from the two controllers. Signed-off-by: Tejun Heo <redacted> Cc: Neil Horman <redacted> Cc: Thomas Graf <tgraf-G/eBtMaohhA@public.gmane.org> Cc: "David S. Miller" <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
Acked-by: Neil Horman <redacted>