Thread (3 messages) 3 messages, 3 authors, 2013-11-20

Re: [PATCH] blkcg: have bh disable for 32bit UP system reading 64bit stats

From: Jens Axboe <axboe@kernel.dk>
Date: 2013-11-20 17:32:15
Also in: lkml

On 11/20/2013 10:24 AM, Tejun Heo wrote:
On Wed, Nov 06, 2013 at 07:14:44PM +0800, Hong Zhiguo wrote:
quoted
From: Hong Zhiguo <redacted>

Update of blkg_stat and blkg_rwstat may happen in bh context.
While u64_stats_fetch_retry is only preempt_disable on 32bit
UP system. This is not enough to avoid preemption by bh and
may read strange 64 bit value.

Signed-off-by: Hong Zhiguo <redacted>
Acked-by: Tejun Heo <tj@kernel.org>

Jens, can you please pick this one up?  This probably needs to be
tagged for stable too.
Yeah will do, thanks.

-- 
Jens Axboe
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help