Thread (8 messages) 8 messages, 2 authors, 2013-08-16

Re: [PATCH 2/2] cpuset: remove redundant checks in file write functions

From: Tejun Heo <hidden>
Date: 2013-08-14 13:30:54
Also in: lkml

Hello, Li.

On Wed, Aug 14, 2013 at 10:01:32AM +0800, Li Zefan wrote:
But most controllers don't check this in those read/write functions.
It shoudn't do any harm not checking online/offline status.
It depends on the specific controller.  For controllers which make
clear distinction between online and offline states for, say,
hierarchical config propagation, it could lead to buggy behavior if
the function body afterwards assume that the current node is online.
I don't know whether this is the case for the functions converted here
but even if so the patch needs to update the description.

Thanks.

-- 
tejun
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help