Re: [PATCH 12/23] cgroup: pass around cgroup_subsys_state instead of cgroup in file methods
From: Vivek Goyal <hidden>
Date: 2013-08-05 14:21:18
Also in:
lkml
On Thu, Aug 01, 2013 at 05:49:50PM -0400, Tejun Heo wrote:
cgroup is currently in the process of transitioning to using struct cgroup_subsys_state * as the primary handle instead of struct cgroup. Please see the previous commit which converts the subsystem methods for rationale. This patch converts all cftype file operations to take @css instead of @cgroup. cftypes for the cgroup core files don't have their subsytem pointer set. These will automatically use the dummy_css added by the previous patch and can be converted the same way. Most subsystem conversions are straight forwards but there are some interesting ones. * freezer: update_if_frozen() is also converted to take @css instead of @cgroup for consistency. This will make the code look simpler too once iterators are converted to use css. * memory/vmpressure: mem_cgroup_from_css() needs to be exported to vmpressure while mem_cgroup_from_cont() can be made static. Updated accordingly. * cpu: cgroup_tg() doesn't have any user left. Removed. * cpuacct: cgroup_ca() doesn't have any user left. Removed. * hugetlb: hugetlb_cgroup_form_cgroup() doesn't have any user left. Removed. * net_cls: cgrp_cls_state() doesn't have any user left. Removed. Signed-off-by: Tejun Heo <redacted> Cc: Li Zefan <redacted> Cc: Peter Zijlstra <redacted> Cc: Ingo Molnar <redacted> Cc: Johannes Weiner <redacted> Cc: Michal Hocko <redacted> Cc: Balbir Singh <redacted> Cc: Aristeu Rozanski <redacted> Cc: Matt Helsley <matthltc-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org> Cc: Daniel Wagner <redacted> Cc: Vivek Goyal <redacted> Cc: Jens Axboe <axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org> Cc: Steven Rostedt <redacted> --- block/blk-cgroup.c | 6 +- block/blk-throttle.c | 32 ++++----- block/cfq-iosched.c | 90 ++++++++++++-------------
blk-cgroup.c, blk-throttle.c and cfq-iosched.c bits look good to me. Acked-by: Vivek Goyal <redacted> Vivek