Re: [PATCH v3 1/8] cgroup: convert cgroup_ida to cgroup_idr

On Tue, Jul 30, 2013 at 09:10:19AM +0800, Li Zefan wrote:

Set cgrp->id to 0? No, 0 is a valid id. The if is here because at first

I don't know.  -1 then?

I called idr_alloc() very late in cgroup_create(), so cgroup_offline_fn()
can be called while cgrp->id hasn't been initialized. Now I can remove
this check.

I'm just a bit apprehensive as IDs will be recycled very fast and
controllers would keep accessing the css and cgroup after offline
until all refs are drained, so it'd be nice if there's some mechanism
to prevent / detect stale ID usages.

Thanks.

-- 
tejun

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>