Re: [PATCH] net: net_cls: fd passed in SCM_RIGHTS datagram not set correctly
From: Daniel Wagner <hidden>
Date: 2013-01-21 10:16:53
Also in:
netdev
From: Daniel Wagner <hidden>
Date: 2013-01-21 10:16:53
Also in:
netdev
On 21.01.2013 10:54, Li Zefan wrote:
On 2013/1/21 17:38, Daniel Wagner wrote:quoted
From: Daniel Wagner <redacted> Commit 6a328d8c6f03501657ad580f6f98bf9a42583ff7 changed the update logic for the socket but it does not update the SCM_RIGHTS update as well. This patch is based on the net_prio fix commit 48a87cc26c13b68f6cce4e9d769fcb17a6b3e4b8 net: netprio: fd passed in SCM_RIGHTS datagram not set correctly A socket fd passed in a SCM_RIGHTS datagram was not getting updated with the new tasks cgrp prioidx. This leaves IO on the socket tagged with the old tasks priority. To fix this add a check in the scm recvmsg path to update the sock cgrp prioidx with the new tasks value. Let's apply the same fix for net_cls. Reported-by: Li Zefan <redacted>Acutally I didn't report this.
You made me look into this, so you reported it at least in my eyes :)
I was about to send exactly the same patch and then I noticed the shared socket issue. ;)
I don't mind if you want your patch to be applied. I just felt responsible for the changes I did. thanks, daniel