Thread (4 messages) 4 messages, 3 authors, 2012-12-20

Re: [PATCH 2/2] vmscan: take at least one pass with shrinkers

From: Dave Chinner <david@fromorbit.com>
Date: 2012-12-20 07:08:52
Also in: linux-fsdevel, linux-mm

On Wed, Dec 19, 2012 at 12:40:18PM +0400, Glauber Costa wrote:
In very low free kernel memory situations, it may be the case that we
have less objects to free than our initial batch size. If this is the
case, it is better to shrink those, and open space for the new workload
then to keep them and fail the new allocations.

More specifically, this happens because we encode this in a loop with
the condition: "while (total_scan >= batch_size)". So if we are in such
a case, we'll not even enter the loop.

This patch modifies turns it into a do () while {} loop, that will
guarantee that we scan it at least once, while keeping the behaviour
exactly the same for the cases in which total_scan > batch_size.
Looks good to me, seems to work just fine.

Reviewed-by: Dave Chinner <redacted>

-- 
Dave Chinner
david@fromorbit.com

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help