Re: [PATCH v2 UPDATE] mm/hugetlb: create hugetlb cgroup file in hugetlb_init

On 2012/12/13 21:56, Michal Hocko wrote:

On Thu 13-12-12 11:39:17, Jianguo Wu wrote:

quoted

Build kernel with CONFIG_HUGETLBFS=y,CONFIG_HUGETLB_PAGE=y
and CONFIG_CGROUP_HUGETLB=y, then specify hugepagesz=xx boot option,
system will boot fail.

This failure is caused by following code path:
setup_hugepagesz
	hugetlb_add_hstate
		hugetlb_cgroup_file_init
			cgroup_add_cftypes
				kzalloc <--slab is *not available* yet

For this path, slab is not available yet, so memory allocated will be
failed, and cause WARN_ON() in hugetlb_cgroup_file_init().

So I move hugetlb_cgroup_file_init() into hugetlb_init().

Changelog:
  do code refactor as suggesting by Aneesh
  add Reviewed-by and Acked-by 

Signed-off-by: Jianguo Wu <redacted>
Signed-off-by: Jiang Liu <redacted>
Reviewed-by: Aneesh Kumar K.V <redacted>
Acked-by: Michal Hocko <redacted>

Any reason to not add Cc: stable as I suggested earlier?

Hi Michal,

Sorry for forgot that.
Andrew has added Cc: stable when added to -mm tree.