Re: [PATCH 1/3] cpuset: implement cgroup_rightmost_descendant()

On Wed 28-11-12 14:26:59, Tejun Heo wrote:

Implement cgroup_rightmost_descendant() which returns the right most
descendant of the specified cgroup.  This can be used to skip the
cgroup's subtree while iterating with
cgroup_for_each_descendant_pre().

Signed-off-by: Tejun Heo <redacted>
Cc: Michal Hocko <redacted>

Acked-by: Michal Hocko <redacted>

Just a nit bellow

[...]

+/**
+ * cgroup_rightmost_descendant - return the rightmost descendant of a cgroup
+ * @cgrp: cgroup of interest
+ *
+ * Return the rightmost descendant of @cgrp.  If there's no descendant,
+ * @cgrp is returned.  This can be used during pre-order traversal to skip
+ * subtree of @cgrp.
+ */

s/cgrp/pos/

+struct cgroup *cgroup_rightmost_descendant(struct cgroup *pos)

[...]

Thanks
-- 
Michal Hocko
SUSE Labs