Thread (54 messages) 54 messages, 5 authors, 2012-11-02

Re: [PATCH 2/8] cgroup: kill CSS_REMOVED

From: Tejun Heo <hidden>
Date: 2012-10-31 17:25:31
Also in: lkml

Hello,

On Wed, Oct 31, 2012 at 09:19:51PM +0400, Glauber Costa wrote:
I don't see post_create failing as a huge problem. The natural
synchronization point would be "right after post_create" - then you can
definitely tell that it is online. Although this can be viewed a bit as
"exposing internals", creating is different then destroying: When you
create, you may not have all data yet. When destroying, you do - and
want to get rid of it. So this kind of bootstrapping is pretty standard
and common.
More proper names for these callbacks would be,

	->allocate()
	->online()
	->offline()
	->free()

And I may rename them.  I don't wanna make ->online() failable.  Why
can't you just allocate everything from ->allocate() and use it from
->online()?

Thanks.

-- 
tejun
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help