Thread (32 messages) 32 messages, 5 authors, 2012-10-25

Re: [PATCH 4/6] cgroups: forbid pre_destroy callback to fail

From: Michal Hocko <hidden>
Date: 2012-10-19 13:34:18
Also in: linux-mm, lkml

On Thu 18-10-12 15:46:06, Tejun Heo wrote:
On Thu, Oct 18, 2012 at 03:41:48PM -0700, Tejun Heo wrote:
quoted
Note that the patch is broken in a couple places but it does show the
general direction.  I'd prefer if patch #3 simply makes pre_destroy()
return 0 and drop __DEPRECATED_clear_css_refs from mem_cgroup_subsys.
Then, I can pull the branch in and drop all the unnecessary cruft.
But you need the locking change for further memcg cleanup.  To avoid
interlocked pulls from both sides, I think it's okay to push this one
with the rest of memcg changes.  I can do the cleanup on top of this
whole series, but please do drop .__DEPRECATED_clear_css_refs from
memcg.
OK I will drop that one.
 Acked-by: Tejun Heo [off-list ref]
Do you still agree with the v2 based on Li's feedback?

Thanks
-- 
Michal Hocko
SUSE Labs
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help