Re: [PATCH mmotm] mm, oom: reduce dependency on tasklist_lock: fix

[patch 1/3] mm, oom: move declaration for mem_cgroup_out_of_memory to oom.h · David Rientjes <rientjes@google.com> · 2012-06-26
[rfc][patch 2/3] mm, oom: introduce helper function to process threads during scan · David Rientjes <rientjes@google.com> · 2012-06-26
Re: [rfc][patch 2/3] mm, oom: introduce helper function to process threads during scan · Kamezawa Hiroyuki <hidden> · 2012-06-26
Re: [rfc][patch 2/3] mm, oom: introduce helper function to process threads during scan · KOSAKI Motohiro <hidden> · 2012-06-26
Re: [rfc][patch 2/3] mm, oom: introduce helper function to process threads during scan · Michal Hocko <hidden> · 2012-06-26
[rfc][patch 3/3] mm, memcg: introduce own oom handler to iterate only over its own threads · David Rientjes <rientjes@google.com> · 2012-06-26
Re: [rfc][patch 3/3] mm, memcg: introduce own oom handler to iterate only over its own threads · Kamezawa Hiroyuki <hidden> · 2012-06-26
Re: [rfc][patch 3/3] mm, memcg: introduce own oom handler to iterate only over its own threads · David Rientjes <rientjes@google.com> · 2012-06-26
Re: [rfc][patch 3/3] mm, memcg: introduce own oom handler to iterate only over its own threads · David Rientjes <rientjes@google.com> · 2012-06-27
Re: [rfc][patch 3/3] mm, memcg: introduce own oom handler to iterate only over its own threads · David Rientjes <rientjes@google.com> · 2012-06-28
Re: [rfc][patch 3/3] mm, memcg: introduce own oom handler to iterate only over its own threads · Oleg Nesterov <oleg@redhat.com> · 2012-06-28
Re: [rfc][patch 3/3] mm, memcg: introduce own oom handler to iterate only over its own threads · David Rientjes <rientjes@google.com> · 2012-06-29
Re: [rfc][patch 3/3] mm, memcg: introduce own oom handler to iterate only over its own threads · Kamezawa Hiroyuki <hidden> · 2012-06-28
Re: [rfc][patch 3/3] mm, memcg: introduce own oom handler to iterate only over its own threads · David Rientjes <rientjes@google.com> · 2012-06-29
Re: [rfc][patch 3/3] mm, memcg: introduce own oom handler to iterate only over its own threads · Oleg Nesterov <oleg@redhat.com> · 2012-07-03
Re: [rfc][patch 3/3] mm, memcg: introduce own oom handler to iterate only over its own threads · Kamezawa Hiroyuki <hidden> · 2012-06-28
Re: [rfc][patch 3/3] mm, memcg: introduce own oom handler to iterate only over its own threads · Michal Hocko <hidden> · 2012-06-26
Re: [patch 1/3] mm, oom: move declaration for mem_cgroup_out_of_memory to oom.h · Kamezawa Hiroyuki <hidden> · 2012-06-26
Re: [patch 1/3] mm, oom: move declaration for mem_cgroup_out_of_memory to oom.h · KOSAKI Motohiro <hidden> · 2012-06-26
Re: [patch 1/3] mm, oom: move declaration for mem_cgroup_out_of_memory to oom.h · Michal Hocko <hidden> · 2012-06-26
[patch 1/5] mm, oom: move declaration for mem_cgroup_out_of_memory to oom.h · David Rientjes <rientjes@google.com> · 2012-06-29
[patch 2/5] mm, oom: introduce helper function to process threads during scan · David Rientjes <rientjes@google.com> · 2012-06-29
Re: [patch 2/5] mm, oom: introduce helper function to process threads during scan · Sha Zhengju <hidden> · 2012-07-12
[patch 3/5] mm, memcg: introduce own oom handler to iterate only over its own threads · David Rientjes <rientjes@google.com> · 2012-06-29
Re: [patch 3/5] mm, memcg: introduce own oom handler to iterate only over its own threads · Andrew Morton <akpm@linux-foundation.org> · 2012-07-10
Re: [patch 3/5] mm, memcg: introduce own oom handler to iterate only over its own threads · David Rientjes <rientjes@google.com> · 2012-07-10
Re: [patch 3/5] mm, memcg: introduce own oom handler to iterate only over its own threads · Sha Zhengju <hidden> · 2012-07-12
[patch 4/5] mm, oom: reduce dependency on tasklist_lock · David Rientjes <rientjes@google.com> · 2012-06-29
Re: [patch 4/5] mm, oom: reduce dependency on tasklist_lock · Oleg Nesterov <oleg@redhat.com> · 2012-07-03
Re: [patch 4/5] mm, oom: reduce dependency on tasklist_lock · David Rientjes <rientjes@google.com> · 2012-07-10
Re: [patch 4/5] mm, oom: reduce dependency on tasklist_lock · Michal Hocko <hidden> · 2012-07-13
[PATCH mmotm] mm, oom: reduce dependency on tasklist_lock: fix · Hugh Dickins <hughd@google.com> · 2012-07-16
Re: [PATCH mmotm] mm, oom: reduce dependency on tasklist_lock: fix · Michal Hocko <hidden> · 2012-07-16
Re: [PATCH mmotm] mm, oom: reduce dependency on tasklist_lock: fix · Hugh Dickins <hughd@google.com> · 2012-07-16
Re: [PATCH mmotm] mm, oom: reduce dependency on tasklist_lock: fix · Michal Hocko <hidden> · 2012-07-16
Re: [PATCH mmotm] mm, oom: reduce dependency on tasklist_lock: fix · Kamezawa Hiroyuki <hidden> · 2012-07-19
[patch 5/5] mm, memcg: move all oom handling to memcontrol.c · David Rientjes <rientjes@google.com> · 2012-06-29
Re: [patch 5/5] mm, memcg: move all oom handling to memcontrol.c · Kamezawa Hiroyuki <hidden> · 2012-07-04
Re: [patch 5/5] mm, memcg: move all oom handling to memcontrol.c · Michal Hocko <hidden> · 2012-07-13
Re: [patch 1/5] mm, oom: move declaration for mem_cgroup_out_of_memory to oom.h · David Rientjes <rientjes@google.com> · 2012-07-10

From: Michal Hocko <hidden>
Date: 2012-07-16 08:06:07
Also in: linux-mm

On Mon 16-07-12 00:42:37, Hugh Dickins wrote:

Slab poisoning gave me a General Protection Fault on the
	atomic_dec(&__task_cred(p)->user->processes);
line of release_task() called from wait_task_zombie(),
every time my dd to USB testing generated a memcg OOM.

Just curious, was it with the wait-on-pagereclaim patch?

oom_kill_process() now does the put_task_struct(),
mem_cgroup_out_of_memory() should not repeat it.

Good catch. I have missed that during review - my bad...

Signed-off-by: Hugh Dickins <redacted>

Acked-by: Michal Hocko <redacted>

quoted hunk ↗ jump to hunk

---

 mm/memcontrol.c |    1 -
 1 file changed, 1 deletion(-)

--- mmotm/mm/memcontrol.c	2012-07-11 14:50:29.808349013 -0700
+++ linux/mm/memcontrol.c	2012-07-15 12:21:26.234289161 -0700

@@ -1533,7 +1533,6 @@ void mem_cgroup_out_of_memory(struct mem
 	points = chosen_points * 1000 / totalpages;
 	oom_kill_process(chosen, gfp_mask, order, points, totalpages, memcg,
 			 NULL, "Memory cgroup out of memory");
-	put_task_struct(chosen);
 }
 
 static unsigned long mem_cgroup_reclaim(struct mem_cgroup *memcg,
--

To unsubscribe from this list: send the line "unsubscribe cgroups" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

-- 
Michal Hocko
SUSE Labs
SUSE LINUX s.r.o.
Lihovarska 1060/12
190 00 Praha 9    
Czech Republic

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help