On Fri, Jul 06, 2012 at 01:19:16PM +0800, Gavin Shan wrote:

On Fri, Jul 06, 2012 at 11:44:57AM +0800, Wanpeng Li wrote:

quoted

From: Wanpeng Li <redacted>

Branch in mem_cgroup_reset only can be RES_MAX_USAGE, RES_FAILCNT.

Signed-off-by: Wanpeng Li <redacted>
---
mm/memcontrol.c |    2 ++
1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/mm/memcontrol.c b/mm/memcontrol.c
index a501660..5e4d1ab 100644
--- a/mm/memcontrol.c
+++ b/mm/memcontrol.c

@@ -3976,6 +3976,8 @@ static int mem_cgroup_reset(struct cgroup *cont, unsigned int event)

		else
			res_counter_reset_failcnt(&memcg->memsw);
		break;
+	default:
+		BUG();

It might be not convinced to have "BUG()" here. You might add
something for debugging purpose. For example,
default:
	printk(KERN_WARNING "%s: Unrecognized name %d\n",
		__func__, name);

But many funtions in mm/memcontrol.c use BUG(), if the branch is not
present. 

Regards,
Wanpeng Li

Thanks,
Gavin

quoted

	}

	return 0;
-- 
1.7.5.4

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>