Re: [PATCH 0/7] Per-cgroup page stat accounting
From: Kamezawa Hiroyuki <hidden>
Date: 2012-06-29 08:26:08
Also in:
linux-mm, lkml
(2012/06/28 19:54), Sha Zhengju wrote:
This patch series provide the ability for each memory cgroup to have independent dirty/writeback page stats. This can provide some information for per-cgroup direct reclaim. Meanwhile, we add more detailed dump messages for memcg OOMs. Three features are included in this patch series: (0).prepare patches for page accounting 1. memcg dirty page accounting 2. memcg writeback page accounting 3. memcg OOMs dump info In (0) prepare patches, we have reworked vfs set page dirty routines to make "modify page info" and "dirty page accouting" stay in one function as much as possible for the sake of memcg bigger lock. These patches are cooked based on Andrew's akpm tree.
Thank you !, it seems good in general. I'll review in detail, later. Do you have any performance comparison between before/after the series ? I mean, set_page_dirty() is the hot-path and we should be careful to add a new accounting. Thanks, -Kame
Sha Zhengju (7): memcg-update-cgroup-memory-document.patch memcg-remove-MEMCG_NR_FILE_MAPPED.patch Make-TestSetPageDirty-and-dirty-page-accounting-in-o.patch Use-vfs-__set_page_dirty-interface-instead-of-doing-.patch memcg-add-per-cgroup-dirty-pages-accounting.patch memcg-add-per-cgroup-writeback-pages-accounting.patch memcg-print-more-detailed-info-while-memcg-oom-happe.patch Documentation/cgroups/memory.txt | 2 + fs/buffer.c | 36 +++++++++----- fs/ceph/addr.c | 20 +------- include/linux/buffer_head.h | 2 + include/linux/memcontrol.h | 27 +++++++--- mm/filemap.c | 5 ++ mm/memcontrol.c | 99 +++++++++++++++++++++++-------------- mm/page-writeback.c | 42 ++++++++++++++-- mm/rmap.c | 4 +- mm/truncate.c | 6 ++ 10 files changed, 159 insertions(+), 84 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
-- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>