Re: [PATCH v3 3/4] memcg: optimize memcg_get_hierarchical_limit
From: Kamezawa Hiroyuki <hidden>
Date: 2012-06-25 09:54:54
Also in:
lkml
(2012/06/25 17:44), Wanpeng Li wrote:
From: Wanpeng Li <redacted> Optimize memcg_get_hierarchical_limit to save cpu cycle. Signed-off-by: Wanpeng Li <redacted>
I can't understand the benefit of this patch to the real world... So, if you wrote the patch description as "clean up" rather than optimize, ok, I'll agree. Thanks, -Kame
quoted hunk ↗ jump to hunk
--- mm/memcontrol.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/mm/memcontrol.c b/mm/memcontrol.c index 2e81328..4520b57 100644 --- a/mm/memcontrol.c +++ b/mm/memcontrol.c@@ -3917,9 +3917,9 @@ static void memcg_get_hierarchical_limit(struct mem_cgroup *memcg, min_limit = res_counter_read_u64(&memcg->res, RES_LIMIT); min_memsw_limit = res_counter_read_u64(&memcg->memsw, RES_LIMIT); - cgroup = memcg->css.cgroup; if (!memcg->use_hierarchy) goto out; + cgroup = memcg->css.cgroup; while (cgroup->parent) { cgroup = cgroup->parent;