Thread (59 messages) 59 messages, 5 authors, 2012-07-25

Re: [PATCH v4 05/25] memcg: Always free struct memcg through schedule_work()

From: Glauber Costa <hidden>
Date: 2012-06-18 12:12:57
Also in: linux-mm, lkml

On 06/18/2012 04:07 PM, Kamezawa Hiroyuki wrote:
(2012/06/18 19:27), Glauber Costa wrote:
quoted
Right now we free struct memcg with kfree right after a
rcu grace period, but defer it if we need to use vfree() to get
rid of that memory area. We do that by need, because we need vfree
to be called in a process context.

This patch unifies this behavior, by ensuring that even kfree will
happen in a separate thread. The goal is to have a stable place to
call the upcoming jump label destruction function outside the realm
of the complicated and quite far-reaching cgroup lock (that can't be
held when calling neither the cpu_hotplug.lock nor the jump_label_mutex)

Signed-off-by: Glauber Costa<redacted>
CC: Tejun Heo<tj@kernel.org>
CC: Li Zefan<redacted>
CC: Kamezawa Hiroyuki<redacted>
CC: Johannes Weiner<hannes@cmpxchg.org>
CC: Michal Hocko<redacted>
How about cut out this patch and merge first as simple cleanu up and
to reduce patch stack on your side ?

Acked-by: KAMEZAWA Hiroyuki <redacted>
I believe this is already in the -mm tree (from the sock memcg fixes)

But actually, my main trouble with this series here, is that I am basing
it on Pekka's tree, while some of the fixes are in -mm already.
If I'd base it on -mm I would lose some of the stuff as well.

Maybe Pekka can merge the current -mm with his tree?

So far I am happy with getting comments from people about the code, so I
did not get overly concerned about that.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help