Re: [PATCH v5 2/2] decrement static keys on real destroy time
From: Li Zefan <hidden>
Date: 2012-05-14 01:39:22
Also in:
linux-mm, netdev
+static void disarm_static_keys(struct mem_cgroup *memcg)
+{
+#ifdef CONFIG_INET
+ if (memcg->tcp_mem.cg_proto.activated)
+ static_key_slow_dec(&memcg_socket_limit_enabled);
+#endif
+}Move this inside the ifdef/endif below ? Otherwise I think you'll get compile error if !CONFIG_INET...
quoted hunk ↗ jump to hunk
+ #ifdef CONFIG_INET struct cg_proto *tcp_proto_cgroup(struct mem_cgroup *memcg) {@@ -452,6 +462,11 @@ struct cg_proto *tcp_proto_cgroup(struct mem_cgroup *memcg) } EXPORT_SYMBOL(tcp_proto_cgroup); #endif /* CONFIG_INET */ +#else +static inline void disarm_static_keys(struct mem_cgroup *memcg) +{ +} + #endif /* CONFIG_CGROUP_MEM_RES_CTLR_KMEM */