Re: [PATCH 10/12] container quota: bill container inodes alloc/free on ext4.

On 05/31/2012 10:37 AM, Jeff Liu wrote:

On 05/31/2012 09:54 AM, Ted Ts'o wrote:

quoted

On Thu, May 31, 2012 at 09:43:18AM +0800, Jeff Liu wrote:

quoted

I also think that is stupid to change all of the file systems with those
hook routines.
At first I have tried to change the quota layer by adding
ns_dquot_<foo>() to the corresponding dquot_<foo>(), it could works on
ext4, and it should works on other file systems which are tightly bound
to VFS quota IMHO.

However, XFS has its own quota management subsystem, with looser binding
to VFS quota.  That's why am trying to export those routines over all
the file systems and CC to the maintainers, sorry for the noise.

No worries about the noise.  I was just trying to suggest something
that might be easier for you.

As near as I can tell XFS doesn't use the fs/quota functions at all,
yes?  But if you add it into the fs/quota functions, it should get you
integration with ext2, ext3, ext4, jfs, ocfs2, and reiserfs.  Yes?

Yes, I just took a quick look through over ocfs2, reiserfs and jfs, they
are all ok.

Such being the case, maybe I should tight ns_dquot_<foo>() to VFS quota
to reduce duplication firstly, at lease, it could works with most file
systems.  Then consider another way to let it works with other file
systems doesn't use fs/quota.

Thanks,
-Jeff

Thanks,
-Jeff

quoted

	    	       	     	   	       - Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html