Re: [PATCH -V6 06/14] hugetlb: Simplify migrate_huge_page
From: David Rientjes <hidden>
Date: 2012-05-24 21:35:12
Also in:
linux-mm, lkml
From: David Rientjes <hidden>
Date: 2012-05-24 21:35:12
Also in:
linux-mm, lkml
On Mon, 16 Apr 2012, Aneesh Kumar K.V wrote:
diff --git a/mm/memory-failure.c b/mm/memory-failure.c index 97cc273..1f092db 100644 --- a/mm/memory-failure.c +++ b/mm/memory-failure.c@@ -1414,7 +1414,6 @@ static int soft_offline_huge_page(struct page *page, int flags) int ret; unsigned long pfn = page_to_pfn(page); struct page *hpage = compound_head(page); - LIST_HEAD(pagelist); ret = get_any_page(page, pfn, flags); if (ret < 0)@@ -1429,19 +1428,11 @@ static int soft_offline_huge_page(struct page *page, int flags) } /* Keep page count to indicate a given hugepage is isolated. */ - - list_add(&hpage->lru, &pagelist); - ret = migrate_huge_pages(&pagelist, new_page, MPOL_MF_MOVE_ALL, 0, - true); + ret = migrate_huge_page(page, new_page, MPOL_MF_MOVE_ALL, 0, true);
Was this tested? Shouldn't this be migrate_huge_page(compound_head(page), ...)?