Re: [PATCH v2 19/29] skip memcg kmem allocations in specified code regions
From: KAMEZAWA Hiroyuki <hidden>
Date: 2012-05-15 02:49:14
Also in:
linux-mm, lkml
(2012/05/12 2:44), Glauber Costa wrote:
This patch creates a mechanism that skip memcg allocations during certain pieces of our core code. It basically works in the same way as preempt_disable()/preempt_enable(): By marking a region under which all allocations will be accounted to the root memcg. We need this to prevent races in early cache creation, when we allocate data using caches that are not necessarily created already. Signed-off-by: Glauber Costa <redacted> CC: Christoph Lameter <redacted> CC: Pekka Enberg <redacted> CC: Michal Hocko <redacted> CC: Kamezawa Hiroyuki <redacted> CC: Johannes Weiner <hannes@cmpxchg.org> CC: Suleiman Souhlal <redacted>
The concept seems okay to me but...
quoted hunk ↗ jump to hunk
--- include/linux/sched.h | 1 + mm/memcontrol.c | 25 +++++++++++++++++++++++++ 2 files changed, 26 insertions(+), 0 deletions(-)diff --git a/include/linux/sched.h b/include/linux/sched.h index 81a173c..0501114 100644 --- a/include/linux/sched.h +++ b/include/linux/sched.h@@ -1613,6 +1613,7 @@ struct task_struct { unsigned long nr_pages; /* uncharged usage */ unsigned long memsw_nr_pages; /* uncharged mem+swap usage */ } memcg_batch; + atomic_t memcg_kmem_skip_account;
If only 'current' thread touch this, you don't need to make this atomic counter. you can use 'long'. Thanks, -Kame -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>