Re: [Lsf] [RFC] writeback and cgroup
From: Vivek Goyal <vgoyal@redhat.com>
Date: 2012-04-16 15:52:07
Also in:
linux-fsdevel, linux-mm, lkml
On Mon, Apr 16, 2012 at 09:07:07PM +0800, Fengguang Wu wrote: [..]
Vivek, I noticed these lines in cfq code
sscanf(dev_name(bdi->dev), "%u:%u", &major, &minor);
Why not use bdi->dev->devt? The problem is that dev_name() will
return "btrfs-X" for btrfs rather than "major:minor".
Isn't bdi->dev->devt 0? I see following code.
add_disk()
bdi_register_dev()
bdi_register()
device_create_vargs(MKDEV(0,0))
dev->devt = devt = MKDEV(0,0);
So for normal block devices, I think bdi->dev->devt will be zero, that's
why probably we don't use it.
Thanks
Vivek
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>