[PATCH 6/6] cls_cgroup: remove redundant rcu_read_lock/unlock
From: Li Zefan <hidden>
Date: 2012-02-01 06:54:00
Also in:
lkml, netdev
Subsystem:
networking [general], networking [sockets], the rest · Maintainers:
"David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Kuniyuki Iwashima, Willem de Bruijn, Linus Torvalds
We've already used rcu_read_lock/unlock inside task_classid(), so don't use the lock/unlock pair twice in this hot path. Signed-off-by: Li Zefan <redacted> --- net/core/sock.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/net/core/sock.c b/net/core/sock.c
index 213c856..c0bab23 100644
--- a/net/core/sock.c
+++ b/net/core/sock.c@@ -1160,9 +1160,7 @@ void sock_update_classid(struct sock *sk) { u32 classid; - rcu_read_lock(); /* doing current task, which cannot vanish. */ classid = task_cls_classid(current); - rcu_read_unlock(); if (classid && classid != sk->sk_classid) sk->sk_classid = classid; }
--
1.7.3.1