Re: [PATCH] cgroup: remove extra calls to find_existing_css_set
flat view
From: Tejun Heo <hidden>
Date: 2012-01-29 20:37:56
Also in:
lkml
Hello, Manddep. On Tue, Jan 24, 2012 at 10:26:31AM -0800, Mandeep Singh Baines wrote:
In cgroup_attach_proc, we indirectly call find_existing_css_set 3 times. It is an expensive call so we want to call it a minimum of times. This patch only calls it once and stores the result so that it can be used later on when we call cgroup_task_migrate. This required modifying cgroup_task_migrate to take the new css_set (which we obtained from find_css_set) as a parameter. The nice side effect of this is that cgroup_task_migrate is now identical for cgroup_attach_task and cgroup_attach_proc. It also now returns a void since it can never fail. Changes in V5: * https://lkml.org/lkml/2012/1/20/344 (Tejun Heo) * Remove css_set_refs
^^^^^^^^^^^^
quoted hunk ↗ jump to hunk
static int cgroup_attach_proc(struct cgroup *cgrp, struct task_struct *leader) { - int retval, i, group_size; + int retval, i, group_size, css_set_refs = 0;
^^^^^^^^^^^^ Wrong patch? Thanks. -- tejun