Re: [PATCH] memcg: fix compile warning on non-numa systems
From: Michal Hocko <hidden>
Date: 2012-01-26 09:01:21
Also in:
linux-mm, lkml
On Thu 26-01-12 00:55:21, Andrew Morton wrote:
On Mon, 16 Jan 2012 09:47:15 +0100 Michal Hocko [off-list ref] wrote:quoted
On Mon 16-01-12 14:04:53, Li Zefan wrote:quoted
Fix this warning: CC mm/memcontrol.o mm/memcontrol.c: In function 'memcg_check_events': mm/memcontrol.c:779:22: warning: unused variable 'do_numainfo'This has been already posted by Kirill and I didn't like the solution (https://lkml.org/lkml/2011/12/27/86). He then reposted with a different version (https://lkml.org/lkml/2012/1/6/281). The later one looks better but I still think this is not worth complicate the code just to get rid of this warning.This?
Haven't seen this one but it looks sane. Acked-by: Michal Hocko <redacted>
quoted hunk ↗ jump to hunk
--- a/mm/memcontrol.c~a +++ a/mm/memcontrol.c@@ -776,7 +776,8 @@ static void memcg_check_events(struct me /* threshold event is triggered in finer grain than soft limit */ if (unlikely(mem_cgroup_event_ratelimit(memcg, MEM_CGROUP_TARGET_THRESH))) { - bool do_softlimit, do_numainfo; + bool do_softlimit; + bool do_numainfo __maybe_unused; do_softlimit = mem_cgroup_event_ratelimit(memcg, MEM_CGROUP_TARGET_SOFTLIMIT);_
-- Michal Hocko SUSE Labs SUSE LINUX s.r.o. Lihovarska 1060/12 190 00 Praha 9 Czech Republic